OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 12:20:00 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Only create backdrop when originating element is invalidated

Browse Source
This commit is contained in:
Gingeh 2025-04-13 18:58:40 +10:00 committed by Andrew Kaster
parent 6dd2a4c945
commit bbf4f546af
3 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibWeb/Layout/TreeBuilder.cpp
View File

@ -570,6 +570,9 @@ void TreeBuilder::update_layout_tree(DOM::Node& dom_node, TreeBuilder::Context&
if (top_layer_element->rendered_in_top_layer()) {
// Each element rendered in the top layer has a ::backdrop pseudo-element, for which it is the originating element.
[&]() {
if (!should_create_layout_node && !top_layer_element->needs_layout_tree_update())
return;
if (top_layer_element->has_inclusive_ancestor_with_display_none())
return;

26
Tests/LibWeb/Layout/expected/layout-tree-update/dialog-backdrop-update.txt Normal file
View File

@ -0,0 +1,26 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x0 children: inline
TextNode <#text>
TextNode <#text>
TextNode <#text>
BlockContainer <(anonymous)> at (0,0) content-size 800x600 positioned [BFC] children: not-inline
BlockContainer <dialog#dialog> at (395.140625,291.5) content-size 9.703125x17 positioned [BFC] children: not-inline
BlockContainer <(anonymous)> at (395.140625,291.5) content-size 9.703125x0 children: inline
TextNode <#text>
BlockContainer <div#inner> at (395.140625,291.5) content-size 9.703125x17 children: inline
frag 0 from TextNode start: 0, length: 1, rect: [395.140625,291.5 9.703125x17] baseline: 13.296875
"x"
TextNode <#text>
BlockContainer <(anonymous)> at (395.140625,308.5) content-size 9.703125x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x16]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x0]
PaintableWithLines (BlockContainer(anonymous)) [0,0 800x600]
PaintableWithLines (BlockContainer<DIALOG>#dialog) [376.140625,272.5 47.703125x55]
PaintableWithLines (BlockContainer(anonymous)) [395.140625,291.5 9.703125x0]
PaintableWithLines (BlockContainer<DIV>#inner) [395.140625,291.5 9.703125x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [395.140625,308.5 9.703125x0]

13
Tests/LibWeb/Layout/input/layout-tree-update/dialog-backdrop-update.html Normal file
View File

@ -0,0 +1,13 @@
<!DOCTYPE html>
<body>
<dialog id="dialog">
<div id="inner"></div>
</dialog>
</body>
<script>
dialog.showModal();
document.body.offsetWidth;
inner.prepend("x");
document.body.offsetWidth;
</script>