OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Make text cursor same height as text

Browse Source 
Previously we would paint the cursor the entire height of the text
fragment - this didn't look great with large line-heights. Now we only
paint it the height of the actual text, with the top of the cursor
aligning with the font "ascent" and the bottom the "descent".
This commit is contained in:
Callum Law 2025-08-17 01:03:44 +12:00 committed by Andreas Kling
parent 71b039a721
commit ba62679a7a
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Libraries/LibWeb/Painting/PaintableBox.cpp
View File

@ -723,11 +723,15 @@ void paint_cursor_if_needed(DisplayListRecordingContext& context, TextPaintable
auto const& font = fragment.glyph_run() ? fragment.glyph_run()->font() : fragment.layout_node().first_available_font();
auto cursor_offset = font.width(text.substring_view(0, cursor_position->offset() - fragment.start_offset()));
auto font_metrics = font.pixel_metrics();
auto cursor_height = font_metrics.ascent + font_metrics.descent;
CSSPixelRect cursor_rect {
fragment_rect.x() + CSSPixels::nearest_value_for(cursor_offset),
fragment_rect.top(),
fragment_rect.top() + fragment.baseline() - CSSPixels::nearest_value_for(font_metrics.ascent),
1,
fragment_rect.height()
CSSPixels::nearest_value_for(cursor_height)
};
auto cursor_device_rect = context.rounded_device_rect(cursor_rect).to_type<int>();