OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Check if transform is identity instead of has_css_transform()

Browse Source 
...in clip and scroll frames calculation algorithm.

Fix a regression from 719a50c where display-list recording disagreed
with the clipping logic about whether a stacking context is transformed.
`has_css_transform()` returns true whenever the computed transform is
not `none`, which differs from an identity-matrix check. These yield
different results for cases like `translate(0, 0)`.
This commit is contained in:
Aliaksandr Kalenik 2025-09-23 21:43:44 +02:00 committed by Alexander Kalenik
parent 719a50c9bf
commit 9bbc1cd618
4 changed files with 43 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/Painting/StackingContext.cpp
View File

@ -326,10 +326,8 @@ void StackingContext::paint(DisplayListRecordingContext& context) const
push_stacking_context_params.clip_path = path.copy_transformed(Gfx::AffineTransform {}.set_scale(device_pixel_scale, device_pixel_scale).set_translation(source_paintable_rect.location().to_type<float>())); push_stacking_context_params.clip_path = path.copy_transformed(Gfx::AffineTransform {}.set_scale(device_pixel_scale, device_pixel_scale).set_translation(source_paintable_rect.location().to_type<float>()));
} }
auto has_css_transform = paintable_box().has_css_transform(); if (!transform_matrix.is_identity())
if (has_css_transform) {
paintable_box().apply_clip_overflow_rect(context, PaintPhase::Foreground); paintable_box().apply_clip_overflow_rect(context, PaintPhase::Foreground);
}
paintable_box().apply_scroll_offset(context); paintable_box().apply_scroll_offset(context);
auto mask_image = computed_values.mask_image(); auto mask_image = computed_values.mask_image();
@ -376,7 +374,7 @@ void StackingContext::paint(DisplayListRecordingContext& context) const
context.display_list_recorder().restore(); context.display_list_recorder().restore();
} }
paintable_box().reset_scroll_offset(context); paintable_box().reset_scroll_offset(context);
if (has_css_transform) if (!transform_matrix.is_identity())
paintable_box().clear_clip_overflow_rect(context, PaintPhase::Foreground); paintable_box().clear_clip_overflow_rect(context, PaintPhase::Foreground);
} }

6
Libraries/LibWeb/Painting/ViewportPaintable.cpp
View File

@ -147,9 +147,8 @@ void ViewportPaintable::assign_clip_frames()
} }
break; break;
} }
if (block->has_css_transform()) { if (!block->transform().is_identity())
break; break;
}
} }
return TraversalDecision::Continue; return TraversalDecision::Continue;
}); });
@ -213,9 +212,8 @@ void ViewportPaintable::assign_clip_frames()
clip_frame.add_clip_rect(clip_rect, {}, block_paintable_box.enclosing_scroll_frame()); clip_frame.add_clip_rect(clip_rect, {}, block_paintable_box.enclosing_scroll_frame());
} }
} }
if (block->has_css_transform()) { if (!block_paintable_box.transform().is_identity())
break; break;
}
} }
} }
} }

8
Tests/LibWeb/Ref/expected/overflow-hidden-8-ref.html Normal file
View File

@ -0,0 +1,8 @@
<!DOCTYPE html><style>
#inner {
background-color: blueviolet;
width: 100px;
height: 100px;
border-radius: 9999px;
}
</style><div id="inner">

31
Tests/LibWeb/Ref/input/overflow-hidden-8.html Normal file
View File

@ -0,0 +1,31 @@
<!DOCTYPE html>
<link rel="match" href="../expected/overflow-hidden-8-ref.html" />
<meta name="fuzzy" content="maxDifference=0-1;totalPixels=0-70">
<style>
#outer {
width: 100px;
height: 100px;
overflow: hidden;
position: absolute;
border-radius: 9999px;
}
#middle {
overflow: hidden;
position: absolute;
transform: translateZ(0px);
right: 0;
bottom: 0;
left: 0;
top: 0;
}
#inner {
background-color: blueviolet;
position: absolute;
height: 100%;
left: 0;
top: 0;
bottom: 0;
right: 0;
width: 100%;
}
</style><div id="outer"><div id="middle"><div id="inner">