OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Remove a popover AD-HOC comment after spec update

Browse Source 
See https://github.com/whatwg/html/pull/11197
This commit is contained in:
Gingeh 2025-04-23 16:40:44 +10:00 committed by Tim Ledbetter
parent 04d7228c51
commit 7b8af4d84c
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/HTML/HTMLElement.cpp
View File

@ -1400,9 +1400,7 @@ WebIDL::ExceptionOr<void> HTMLElement::hide_popover(FocusPreviousElement focus_p
}
};
// AD-HOC: This implementation checks "opened in popover mode" instead of the current popover state.
// Spec issue: https://github.com/whatwg/html/issues/10996.
// 7. If element's popover attribute is in the auto state or the hint state, then:
// 7. If element's opened in popover mode is "auto" or "hint", then:
if (m_opened_in_popover_mode.has_value() && m_opened_in_popover_mode.value().is_one_of("auto", "hint")) {
// 7.1. Run hide all popovers until given element, focusPreviousElement, and fireEvents.
hide_all_popovers_until(GC::Ptr(this), focus_previous_element, fire_events);