OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Don't invalidate layout tree on all DOM node removals

Browse Source 
DOM nodes that didn't have a layout node before being removed from the
DOM are not going to change the shape of the layout tree after being
removed.

Observing this, we can avoid a full layout tree rebuild on some DOM node
removals.

This avoids a bunch of tree building work when loading https://x.com/
This commit is contained in:
Andreas Kling 2024-09-19 07:43:15 +02:00 committed by Andreas Kling
parent aa8f17aea4
commit 6f34758947
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Userland/Libraries/LibWeb/DOM/Node.cpp
View File

@ -714,6 +714,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<Node>> Node::append_child(JS::NonnullGCPtr<
void Node::remove(bool suppress_observers)
{
bool was_connected = is_connected();
bool had_layout_node = layout_node();
// 1. Let parent be node’s parent
auto* parent = this->parent();
@ -855,7 +856,12 @@ void Node::remove(bool suppress_observers)
// Since the tree structure has changed, we need to invalidate both style and layout.
// In the future, we should find a way to only invalidate the parts that actually need it.
document().invalidate_style(StyleInvalidationReason::NodeRemove);
document().invalidate_layout_tree();
// NOTE: If we didn't have a layout node before, rebuilding the layout tree isn't gonna give us one
// after we've been removed from the DOM.
if (had_layout_node) {
document().invalidate_layout_tree();
}
}
document().bump_dom_tree_version();