OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Avoid overwriting non-animated font-size when computing font

Browse Source 
Previously if we would overwrite the non-animated font-size with the
animated font-size if it was set.

Gains us 8 WPT tests and means we now fail 9 others in line with other
browsers.
This commit is contained in:
Callum Law 2025-08-31 14:29:12 +12:00 committed by Sam Atkins
parent c6049e6853
commit 64d2f0d55a
3 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/CSS/StyleComputer.cpp
View File

@ -1938,7 +1938,7 @@ void StyleComputer::compute_font(ComputedProperties& style, Optional<DOM::Abstra
auto inherited_math_depth = inheritance_parent_has_computed_properties ? inheritance_parent->computed_properties()->math_depth() : InitialValues::math_depth();
auto length_resolution_context = inheritance_parent_has_computed_properties ? Length::ResolutionContext::for_element(inheritance_parent.value()) : Length::ResolutionContext::for_window(*m_document->window());
auto const& font_size_specified_value = style.property(PropertyID::FontSize);
auto const& font_size_specified_value = style.property(PropertyID::FontSize, ComputedProperties::WithAnimationsApplied::No);
style.set_property(
PropertyID::FontSize,

20
Tests/LibWeb/Text/expected/wpt-import/css/css-fonts/animations/font-size-interpolation-001.txt
View File

@ -2,8 +2,8 @@ Harness status: OK
Found 140 tests
118 Pass
22 Fail
126 Pass
14 Fail
Pass CSS Transitions: property <font-size> from neutral to [20px] at (-2) should be [0px]
Pass CSS Transitions: property <font-size> from neutral to [20px] at (-0.3) should be [7px]
Pass CSS Transitions: property <font-size> from neutral to [20px] at (0) should be [10px]
@ -19,19 +19,19 @@ Pass CSS Transitions with transition: all: property <font-size> from neutral to
Pass CSS Transitions with transition: all: property <font-size> from neutral to [20px] at (1) should be [20px]
Pass CSS Transitions with transition: all: property <font-size> from neutral to [20px] at (1.5) should be [25px]
Pass CSS Animations: property <font-size> from neutral to [20px] at (-2) should be [0px]
Fail CSS Animations: property <font-size> from neutral to [20px] at (-0.3) should be [7px]
Pass CSS Animations: property <font-size> from neutral to [20px] at (-0.3) should be [7px]
Pass CSS Animations: property <font-size> from neutral to [20px] at (0) should be [10px]
Fail CSS Animations: property <font-size> from neutral to [20px] at (0.3) should be [13px]
Fail CSS Animations: property <font-size> from neutral to [20px] at (0.6) should be [16px]
Pass CSS Animations: property <font-size> from neutral to [20px] at (0.3) should be [13px]
Pass CSS Animations: property <font-size> from neutral to [20px] at (0.6) should be [16px]
Pass CSS Animations: property <font-size> from neutral to [20px] at (1) should be [20px]
Fail CSS Animations: property <font-size> from neutral to [20px] at (1.5) should be [25px]
Pass CSS Animations: property <font-size> from neutral to [20px] at (1.5) should be [25px]
Pass Web Animations: property <font-size> from neutral to [20px] at (-2) should be [0px]
Fail Web Animations: property <font-size> from neutral to [20px] at (-0.3) should be [7px]
Pass Web Animations: property <font-size> from neutral to [20px] at (-0.3) should be [7px]
Pass Web Animations: property <font-size> from neutral to [20px] at (0) should be [10px]
Fail Web Animations: property <font-size> from neutral to [20px] at (0.3) should be [13px]
Fail Web Animations: property <font-size> from neutral to [20px] at (0.6) should be [16px]
Pass Web Animations: property <font-size> from neutral to [20px] at (0.3) should be [13px]
Pass Web Animations: property <font-size> from neutral to [20px] at (0.6) should be [16px]
Pass Web Animations: property <font-size> from neutral to [20px] at (1) should be [20px]
Fail Web Animations: property <font-size> from neutral to [20px] at (1.5) should be [25px]
Pass Web Animations: property <font-size> from neutral to [20px] at (1.5) should be [25px]
Pass CSS Transitions: property <font-size> from [initial] to [20px] at (-2) should be [8px]
Pass CSS Transitions: property <font-size> from [initial] to [20px] at (-0.3) should be [14.8px]
Pass CSS Transitions: property <font-size> from [initial] to [20px] at (0) should be [16px]

22
Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/properties-value-inherit-001.txt
View File

@ -2,8 +2,8 @@ Harness status: OK
Found 560 tests
300 Pass
260 Fail
291 Pass
269 Fail
Pass background-color color(rgba) / values
Fail background-color color(rgba) / events
Pass background-position-x length(pt) / values
@ -407,23 +407,23 @@ Fail left percentage(%) / events
Pass color color(rgba) / values
Fail color color(rgba) / events
Pass font-size length(pt) / values
Pass font-size length(pt) / events
Fail font-size length(pt) / events
Pass font-size length(pc) / values
Pass font-size length(pc) / events
Fail font-size length(pc) / events
Pass font-size length(px) / values
Pass font-size length(px) / events
Fail font-size length(px) / events
Pass font-size length(em) / values
Pass font-size length(em) / events
Fail font-size length(em) / events
Pass font-size length(ex) / values
Pass font-size length(ex) / events
Fail font-size length(ex) / events
Pass font-size length(mm) / values
Pass font-size length(mm) / events
Fail font-size length(mm) / events
Pass font-size length(cm) / values
Pass font-size length(cm) / events
Fail font-size length(cm) / events
Pass font-size length(in) / values
Pass font-size length(in) / events
Fail font-size length(in) / events
Pass font-size percentage(%) / values
Pass font-size percentage(%) / events
Fail font-size percentage(%) / events
Pass font-weight font-weight(keyword) / values
Pass font-weight font-weight(keyword) / events
Pass font-weight font-weight(numeric) / values