mirror of
https://github.com/zebrajr/ladybird.git
synced 2025-12-06 00:19:53 +01:00
Revert "WebContent+WebDriver: Inform WebDriver when a window is closed"
This reverts commit 556a0936dd.
This was causing a large slow down in WPT, and a crash on macOS during
session shutdown when running WebDriver manually.
This commit is contained in:
parent
30f59cfe1a
commit
62e732e5ad
|
|
@ -538,9 +538,6 @@ void PageClient::page_did_close_top_level_traversable()
|
|||
// FIXME: Rename this IPC call
|
||||
client().async_did_close_browsing_context(m_id);
|
||||
|
||||
if (m_webdriver)
|
||||
m_webdriver->async_window_closed();
|
||||
|
||||
// NOTE: This only removes the strong reference the PageHost has for this PageClient.
|
||||
// It will be GC'd 'later'.
|
||||
m_owner.remove_page({}, m_id);
|
||||
|
|
|
|||
|
|
@ -1,7 +1,6 @@
|
|||
#include <LibWeb/WebDriver/Response.h>
|
||||
|
||||
endpoint WebDriverServer {
|
||||
window_closed() =|
|
||||
script_executed(Web::WebDriver::Response response) =|
|
||||
actions_performed(Web::WebDriver::Response response) =|
|
||||
}
|
||||
|
|
|
|||
|
|
@ -20,11 +20,6 @@ void WebContentConnection::die()
|
|||
on_close();
|
||||
}
|
||||
|
||||
void WebContentConnection::window_closed()
|
||||
{
|
||||
shutdown();
|
||||
}
|
||||
|
||||
void WebContentConnection::script_executed(Web::WebDriver::Response const& response)
|
||||
{
|
||||
if (on_script_executed)
|
||||
|
|
|
|||
|
|
@ -27,7 +27,6 @@ public:
|
|||
private:
|
||||
virtual void die() override;
|
||||
|
||||
virtual void window_closed() override;
|
||||
virtual void script_executed(Web::WebDriver::Response const&) override;
|
||||
virtual void actions_performed(Web::WebDriver::Response const&) override;
|
||||
};
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user