Revert "WebContent+WebDriver: Inform WebDriver when a window is closed"

This reverts commit 556a0936dd.

This was causing a large slow down in WPT, and a crash on macOS during
session shutdown when running WebDriver manually.
This commit is contained in:
Timothy Flynn 2024-10-07 07:12:07 -04:00 committed by Tim Flynn
parent 30f59cfe1a
commit 62e732e5ad
4 changed files with 0 additions and 10 deletions

View File

@ -538,9 +538,6 @@ void PageClient::page_did_close_top_level_traversable()
// FIXME: Rename this IPC call
client().async_did_close_browsing_context(m_id);
if (m_webdriver)
m_webdriver->async_window_closed();
// NOTE: This only removes the strong reference the PageHost has for this PageClient.
// It will be GC'd 'later'.
m_owner.remove_page({}, m_id);

View File

@ -1,7 +1,6 @@
#include <LibWeb/WebDriver/Response.h>
endpoint WebDriverServer {
window_closed() =|
script_executed(Web::WebDriver::Response response) =|
actions_performed(Web::WebDriver::Response response) =|
}

View File

@ -20,11 +20,6 @@ void WebContentConnection::die()
on_close();
}
void WebContentConnection::window_closed()
{
shutdown();
}
void WebContentConnection::script_executed(Web::WebDriver::Response const& response)
{
if (on_script_executed)

View File

@ -27,7 +27,6 @@ public:
private:
virtual void die() override;
virtual void window_closed() override;
virtual void script_executed(Web::WebDriver::Response const&) override;
virtual void actions_performed(Web::WebDriver::Response const&) override;
};