OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Frameset should be the body element if it comes before body

Browse Source 
Fixes one WPT test: "Frameset followed by body inside the html element"
http://wpt.live/html/dom/documents/dom-tree-accessors/Document.body.html
This commit is contained in:
ronak69 2024-10-12 13:55:25 +00:00 committed by Andrew Kaster
parent 7c50903ddd
commit 5f9a36feac
3 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/DOM/Document-body-element-frameset-before-body.txt Normal file
View File

@ -0,0 +1,2 @@
BODY == BODY
FRAMESET == FRAMESET

17
Tests/LibWeb/Text/input/DOM/Document-body-element-frameset-before-body.html Normal file
View File

@ -0,0 +1,17 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
var doc = document.implementation.createHTMLDocument("");
doc.removeChild(doc.documentElement);
var html = doc.appendChild(doc.createElement("html"));
html.appendChild(doc.createElement("body"));
html.appendChild(doc.createElement("frameset"));
println(`BODY == ${doc.body.tagName}`);
html.firstChild.remove();
html.firstChild.remove();
html.appendChild(doc.createElement("frameset"));
html.appendChild(doc.createElement("body"));
println(`FRAMESET == ${doc.body.tagName}`);
});
</script>

13
Userland/Libraries/LibWeb/DOM/Document.cpp
View File

@ -842,17 +842,18 @@ void Document::set_dir(String const& dir)
html->set_dir(dir);
}
// https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2
HTML::HTMLElement* Document::body()
{
// The body element of a document is the first of the html element's children that is either
// a body element or a frameset element, or null if there is no such element.
auto* html = html_element();
if (!html)
return nullptr;
auto* first_body = html->first_child_of_type<HTML::HTMLBodyElement>();
if (first_body)
return first_body;
auto* first_frameset = html->first_child_of_type<HTML::HTMLFrameSetElement>();
if (first_frameset)
return first_frameset;
for (auto* child = html->first_child(); child; child = child->next_sibling()) {
if (is<HTML::HTMLBodyElement>(*child) || is<HTML::HTMLFrameSetElement>(*child))
return static_cast<HTML::HTMLElement*>(child);
}
return nullptr;
}