OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 12:20:00 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb: Update close_top_level_traversable() to match the spec

Browse Source
This commit is contained in:
Tim Ledbetter 2024-09-20 15:49:33 +01:00 committed by Alexander Kalenik
parent 7a2d837c8a
commit 583eef265f
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp
View File

@ -1031,18 +1031,25 @@ void TraversableNavigable::close_top_level_traversable()
{ {
VERIFY(is_top_level_traversable()); VERIFY(is_top_level_traversable());
// 1. Let toUnload be traversable's active document's inclusive descendant navigables. // 1. If traversable's is closing is true, then return.
if (is_closing())
return;
// 2. Let toUnload be traversable's active document's inclusive descendant navigables.
auto to_unload = active_document()->inclusive_descendant_navigables(); auto to_unload = active_document()->inclusive_descendant_navigables();
// FIXME: 2. If the result of checking if unloading is user-canceled for toUnload is true, then return. // FIXME: 3. If the result of checking if unloading is canceled for toUnload is true, then return.
// 3. Unload the active documents of each of toUnload. // 4. Append the following session history traversal steps to traversable:
for (auto navigable : to_unload) { append_session_history_traversal_steps(JS::create_heap_function(heap(), [this] {
navigable->active_document()->unload(); // 1. Let afterAllUnloads be an algorithm step which destroys traversable.
} auto after_all_unloads = JS::create_heap_function(heap(), [this] {
destroy_top_level_traversable();
});
// 4. Destroy traversable. // 2. Unload a document and its descendants given traversable's active document, null, and afterAllUnloads.
destroy_top_level_traversable(); active_document()->unload_a_document_and_its_descendants({}, after_all_unloads);
}));
} }
// https://html.spec.whatwg.org/multipage/document-sequences.html#destroy-a-top-level-traversable // https://html.spec.whatwg.org/multipage/document-sequences.html#destroy-a-top-level-traversable