OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 12:20:00 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibGC: Delete operators ! and bool from GC::Ref

Browse Source 
The GC::Ref smart pointer is always non-null, so there's no need for it
to be convertible to bool.

This exposed a small number of unnecessary null checks which we remove.
This commit is contained in:
Andreas Kling 2025-10-28 18:48:41 +01:00 committed by Andreas Kling
parent e4e18ca84b
commit 3fb678b376
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Libraries/LibGC/Ptr.h
View File

@ -71,6 +71,9 @@ public:
operator T&() const { return *m_ptr; } operator T&() const { return *m_ptr; }
operator bool() const = delete;
bool operator!() const = delete;
private: private:
T* m_ptr { nullptr }; T* m_ptr { nullptr };
}; };

1
Libraries/LibJS/AST.cpp
View File

@ -322,7 +322,6 @@ ThrowCompletionOr<ECMAScriptFunctionObject*> ClassExpression::create_class_const
} }
auto prototype = Object::create_prototype(realm, proto_parent); auto prototype = Object::create_prototype(realm, proto_parent);
VERIFY(prototype);
// FIXME: Step 14.a is done in the parser. By using a synthetic super(...args) which does not call @@iterator of %Array.prototype% // FIXME: Step 14.a is done in the parser. By using a synthetic super(...args) which does not call @@iterator of %Array.prototype%
auto const& constructor = *m_constructor; auto const& constructor = *m_constructor;

1
Libraries/LibJS/Bytecode/Interpreter.cpp
View File

@ -1344,7 +1344,6 @@ static Value instantiate_ordinary_function_expression(Interpreter& interpreter,
auto environment = GC::Ref { *interpreter.running_execution_context().lexical_environment }; auto environment = GC::Ref { *interpreter.running_execution_context().lexical_environment };
if (has_own_name) { if (has_own_name) {
VERIFY(environment);
environment = new_declarative_environment(*environment); environment = new_declarative_environment(*environment);
MUST(environment->create_immutable_binding(interpreter.vm(), own_name, false)); MUST(environment->create_immutable_binding(interpreter.vm(), own_name, false));
} }