OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 12:20:00 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

UI/Headless: Wait for "reftest-wait" class removal before screenshotting

Browse Source 
Resolves https://github.com/LadybirdBrowser/ladybird/issues/3984
This commit is contained in:
Aliaksandr Kalenik 2025-03-18 17:40:05 +01:00 committed by Jelle Raaijmakers
parent 394073f611
commit 259d39cbad
1 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
UI/Headless/Test.cpp
View File

@ -286,6 +286,27 @@ void run_dump_test(HeadlessWebView& view, Test& test, URL::URL const& url, int t
timer->start(); timer->start();
} }
static String wait_for_reftest_completion = R"(
function hasReftestWaitClass() {
return document.documentElement.classList.contains('reftest-wait');
}
if (!hasReftestWaitClass()) {
internals.signalTestIsDone("PASS");
} else {
const observer = new MutationObserver(() => {
if (!hasReftestWaitClass()) {
internals.signalTestIsDone("PASS");
}
});
observer.observe(document.documentElement, {
attributes: true,
attributeFilter: ['class'],
});
}
)"_string;
static void run_ref_test(HeadlessWebView& view, Test& test, URL::URL const& url, int timeout_in_milliseconds) static void run_ref_test(HeadlessWebView& view, Test& test, URL::URL const& url, int timeout_in_milliseconds)
{ {
auto timer = Core::Timer::create_single_shot(timeout_in_milliseconds, [&view, &test]() { auto timer = Core::Timer::create_single_shot(timeout_in_milliseconds, [&view, &test]() {
@ -343,7 +364,11 @@ static void run_ref_test(HeadlessWebView& view, Test& test, URL::URL const& url,
view.on_test_complete({ test, TestResult::Crashed }); view.on_test_complete({ test, TestResult::Crashed });
}; };
view.on_load_finish = [&view, &test, on_test_complete = move(on_test_complete)](auto const&) { view.on_load_finish = [&view](auto const&) {
view.run_javascript(wait_for_reftest_completion);
};
view.on_test_finish = [&view, &test, on_test_complete = move(on_test_complete)](auto const&) {
if (test.actual_screenshot) { if (test.actual_screenshot) {
if (view.url().query().has_value() && view.url().query()->equals_ignoring_ascii_case("mismatch"sv)) { if (view.url().query().has_value() && view.url().query()->equals_ignoring_ascii_case("mismatch"sv)) {
test.ref_test_expectation_type = RefTestExpectationType::Mismatch; test.ref_test_expectation_type = RefTestExpectationType::Mismatch;
@ -364,10 +389,6 @@ static void run_ref_test(HeadlessWebView& view, Test& test, URL::URL const& url,
} }
}; };
view.on_test_finish = [&](auto const&) {
dbgln("Unexpected text test finished during ref test for {}", url);
};
view.on_set_test_timeout = [timer, timeout_in_milliseconds](double milliseconds) { view.on_set_test_timeout = [timer, timeout_in_milliseconds](double milliseconds) {
if (milliseconds <= timeout_in_milliseconds) if (milliseconds <= timeout_in_milliseconds)
return; return;