OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 12:20:00 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

IDLGenerators: Support null as a default value for dictionary types

Browse Source 
Specifically, NotificationOptions has this:

```webidl
dictionary NotificationOptions {
    // ...
    boolean? silent = null;
    // ...
};
```
https://notifications.spec.whatwg.org/#dictdef-notificationoptions

Without this patch, we generate this code, which isn't valid:

```c++
silent_value_11 = static_cast<bool>(null);
```

Treating `null` the same as no default value seems like the best option,
as they're equivalent in our C++ types.
This commit is contained in:
Sam Atkins 2025-09-18 11:03:15 +01:00
parent 95aceb6ec9
commit 1b8e81cd6f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View File

@ -616,7 +616,9 @@ static void generate_to_integral(SourceGenerator& scoped_generator, ParameterTyp
)~~~"); )~~~");
} }
if (optional_default_value.has_value()) { // FIXME: The Optional<foo> defaults to empty, and can't be explicitly set to `null`.
// So, just skip the assignment.
if (optional_default_value.has_value() && optional_default_value != "null"sv) {
scoped_generator.append(R"~~~( scoped_generator.append(R"~~~(
else else
@cpp_name@ = static_cast<@cpp_type@>(@parameter.optional_default_value@); @cpp_name@ = static_cast<@cpp_type@>(@parameter.optional_default_value@);