OSSForks/ladybird
1
0
Fork 0
mirror of https://github.com/zebrajr/ladybird.git synced 2025-12-06 00:19:53 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

LibWeb/IDB: Resolve FIXME regarding removing from indecies

Browse Source
This commit is contained in:
stelar7 2025-05-13 23:09:28 +02:00 committed by Jelle Raaijmakers
parent 46ecf239c4
commit 13674c1b32
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp
View File

@ -1318,7 +1318,10 @@ JS::Value delete_records_from_an_object_store(GC::Ref<ObjectStore> store, GC::Re
// 1. Remove all records, if any, from store’s list of records with key in range.
store->remove_records_in_range(range);
// FIXME: 2. For each index which references store, remove every record from index’s list of records whose value is in range, if any such records exist.
// 2. For each index which references store, remove every record from index’s list of records whose value is in range, if any such records exist.
for (auto const& [name, index] : store->index_set()) {
index->remove_records_with_value_in_range(range);
}
// 3. Return undefined.
return JS::js_undefined();

7
Libraries/LibWeb/IndexedDB/Internal/Index.cpp
View File

@ -122,4 +122,11 @@ void Index::store_a_record(IndexRecord const& record)
});
}
void Index::remove_records_with_value_in_range(GC::Ref<IDBKeyRange> range)
{
m_records.remove_all_matching([&](auto const& record) {
return range->is_in_range(record.value);
});
}
}

1
Libraries/LibWeb/IndexedDB/Internal/Index.h
View File

@ -45,6 +45,7 @@ public:
GC::ConservativeVector<IndexRecord> first_n_in_range(GC::Ref<IDBKeyRange> range, Optional<WebIDL::UnsignedLong> count);
u64 count_records_in_range(GC::Ref<IDBKeyRange> range);
void store_a_record(IndexRecord const& record);
void remove_records_with_value_in_range(GC::Ref<IDBKeyRange> range);
HTML::SerializationRecord referenced_value(IndexRecord const& index_record) const;