mirror of
https://github.com/zebrajr/express.git
synced 2025-12-06 12:19:51 +01:00
41113599af
Since v5 relies on node >= 18, this is now possible (since v16, v14.18.0 [^1][^2]). It's functionally irrelevant: 1. It's not required for CJS nor ESM (with a few exceptions [^3]) 2. It has no performance promises However, there are upsides to this approach: 1. It brings clear boundaries to what's a built-in and what's an external dependency 2. It reduces the risk of importing unwanted deps where a built-in is expected 3. It's slightly more interoperable with other JS runtimes that provide node compatibility[^4], albeit only during development. Once imported from npm, built-ins are assumed. [^1]:https://nodejs.org/docs/latest-v22.x/api/modules.html#built-in-modules [^2]:https://github.com/nodejs/node/pull/37246 [^3]:https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix [^4]:https://docs.deno.com/runtime/fundamentals/node/#using-node's-built-in-modules
144 lines
2.9 KiB
JavaScript
144 lines
2.9 KiB
JavaScript
'use strict'
|
|
|
|
var after = require('after')
|
|
var express = require('../')
|
|
, request = require('supertest');
|
|
|
|
describe('app', function(){
|
|
describe('.request', function(){
|
|
it('should extend the request prototype', function(done){
|
|
var app = express();
|
|
|
|
app.request.querystring = function(){
|
|
return require('node:url').parse(this.url).query;
|
|
};
|
|
|
|
app.use(function(req, res){
|
|
res.end(req.querystring());
|
|
});
|
|
|
|
request(app)
|
|
.get('/foo?name=tobi')
|
|
.expect('name=tobi', done);
|
|
})
|
|
|
|
it('should only extend for the referenced app', function (done) {
|
|
var app1 = express()
|
|
var app2 = express()
|
|
var cb = after(2, done)
|
|
|
|
app1.request.foobar = function () {
|
|
return 'tobi'
|
|
}
|
|
|
|
app1.get('/', function (req, res) {
|
|
res.send(req.foobar())
|
|
})
|
|
|
|
app2.get('/', function (req, res) {
|
|
res.send(req.foobar())
|
|
})
|
|
|
|
request(app1)
|
|
.get('/')
|
|
.expect(200, 'tobi', cb)
|
|
|
|
request(app2)
|
|
.get('/')
|
|
.expect(500, /(?:not a function|has no method)/, cb)
|
|
})
|
|
|
|
it('should inherit to sub apps', function (done) {
|
|
var app1 = express()
|
|
var app2 = express()
|
|
var cb = after(2, done)
|
|
|
|
app1.request.foobar = function () {
|
|
return 'tobi'
|
|
}
|
|
|
|
app1.use('/sub', app2)
|
|
|
|
app1.get('/', function (req, res) {
|
|
res.send(req.foobar())
|
|
})
|
|
|
|
app2.get('/', function (req, res) {
|
|
res.send(req.foobar())
|
|
})
|
|
|
|
request(app1)
|
|
.get('/')
|
|
.expect(200, 'tobi', cb)
|
|
|
|
request(app1)
|
|
.get('/sub')
|
|
.expect(200, 'tobi', cb)
|
|
})
|
|
|
|
it('should allow sub app to override', function (done) {
|
|
var app1 = express()
|
|
var app2 = express()
|
|
var cb = after(2, done)
|
|
|
|
app1.request.foobar = function () {
|
|
return 'tobi'
|
|
}
|
|
|
|
app2.request.foobar = function () {
|
|
return 'loki'
|
|
}
|
|
|
|
app1.use('/sub', app2)
|
|
|
|
app1.get('/', function (req, res) {
|
|
res.send(req.foobar())
|
|
})
|
|
|
|
app2.get('/', function (req, res) {
|
|
res.send(req.foobar())
|
|
})
|
|
|
|
request(app1)
|
|
.get('/')
|
|
.expect(200, 'tobi', cb)
|
|
|
|
request(app1)
|
|
.get('/sub')
|
|
.expect(200, 'loki', cb)
|
|
})
|
|
|
|
it('should not pollute parent app', function (done) {
|
|
var app1 = express()
|
|
var app2 = express()
|
|
var cb = after(2, done)
|
|
|
|
app1.request.foobar = function () {
|
|
return 'tobi'
|
|
}
|
|
|
|
app2.request.foobar = function () {
|
|
return 'loki'
|
|
}
|
|
|
|
app1.use('/sub', app2)
|
|
|
|
app1.get('/sub/foo', function (req, res) {
|
|
res.send(req.foobar())
|
|
})
|
|
|
|
app2.get('/', function (req, res) {
|
|
res.send(req.foobar())
|
|
})
|
|
|
|
request(app1)
|
|
.get('/sub')
|
|
.expect(200, 'loki', cb)
|
|
|
|
request(app1)
|
|
.get('/sub/foo')
|
|
.expect(200, 'tobi', cb)
|
|
})
|
|
})
|
|
})
|