mirror of
https://github.com/zebrajr/express.git
synced 2025-12-06 00:19:48 +01:00
82fc12a40b
* add test for removing user provided expires
* rework impl and tests to ignore maxAge, do not set it
this is to take into account the built-in relative expires when passing
a maxAge to res.cookie
I realized that using maxAge to invalidate cookies inherrently hit this
relativee expires behavior, and the goal of this PR is not to rework
that relative expires behavior w/ maxAge, but to prevent users from
overwriting these values by accident when clearing cookies
* update history.md
* explicitly delete maxAge instead of setting as undefined
* drop the spread, use object.assign
* wording, review comment on history.md
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
* ♻️ use spread, update supported ecmascript version
---------
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
11 lines
271 B
YAML
11 lines
271 B
YAML
root: true
|
|
env:
|
|
es2022: true
|
|
node: true
|
|
rules:
|
|
eol-last: error
|
|
eqeqeq: [error, allow-null]
|
|
indent: [error, 2, { MemberExpression: "off", SwitchCase: 1 }]
|
|
no-trailing-spaces: error
|
|
no-unused-vars: [error, { vars: all, args: none, ignoreRestSiblings: true }]
|