express/test/req.get.js
Szymon Łągiewka 41113599af fix(refactor): prefix built-in node module imports
Since v5 relies on node >= 18, this is now possible (since v16, v14.18.0
[^1][^2]).

It's functionally irrelevant:
1. It's not required for CJS nor ESM (with a few exceptions [^3])
2. It has no performance promises

However, there are upsides to this approach:
1. It brings clear boundaries to what's a built-in and what's an
external dependency
2. It reduces the risk of importing unwanted deps where a built-in is
expected
3. It's slightly more interoperable with other JS runtimes that provide
node compatibility[^4], albeit only during development. Once imported
from npm, built-ins are assumed.

[^1]:https://nodejs.org/docs/latest-v22.x/api/modules.html#built-in-modules
[^2]:https://github.com/nodejs/node/pull/37246
[^3]:https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix
[^4]:https://docs.deno.com/runtime/fundamentals/node/#using-node's-built-in-modules
2025-01-10 11:53:44 -06:00

61 lines
1.4 KiB
JavaScript

'use strict'
var express = require('../')
, request = require('supertest')
, assert = require('node:assert');
describe('req', function(){
describe('.get(field)', function(){
it('should return the header field value', function(done){
var app = express();
app.use(function(req, res){
assert(req.get('Something-Else') === undefined);
res.end(req.get('Content-Type'));
});
request(app)
.post('/')
.set('Content-Type', 'application/json')
.expect('application/json', done);
})
it('should special-case Referer', function(done){
var app = express();
app.use(function(req, res){
res.end(req.get('Referer'));
});
request(app)
.post('/')
.set('Referrer', 'http://foobar.com')
.expect('http://foobar.com', done);
})
it('should throw missing header name', function (done) {
var app = express()
app.use(function (req, res) {
res.end(req.get())
})
request(app)
.get('/')
.expect(500, /TypeError: name argument is required to req.get/, done)
})
it('should throw for non-string header name', function (done) {
var app = express()
app.use(function (req, res) {
res.end(req.get(42))
})
request(app)
.get('/')
.expect(500, /TypeError: name must be a string to req.get/, done)
})
})
})