mirror of
https://github.com/zebrajr/express.git
synced 2025-12-06 00:19:48 +01:00
41113599af
Since v5 relies on node >= 18, this is now possible (since v16, v14.18.0 [^1][^2]). It's functionally irrelevant: 1. It's not required for CJS nor ESM (with a few exceptions [^3]) 2. It has no performance promises However, there are upsides to this approach: 1. It brings clear boundaries to what's a built-in and what's an external dependency 2. It reduces the risk of importing unwanted deps where a built-in is expected 3. It's slightly more interoperable with other JS runtimes that provide node compatibility[^4], albeit only during development. Once imported from npm, built-ins are assumed. [^1]:https://nodejs.org/docs/latest-v22.x/api/modules.html#built-in-modules [^2]:https://github.com/nodejs/node/pull/37246 [^3]:https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix [^4]:https://docs.deno.com/runtime/fundamentals/node/#using-node's-built-in-modules
107 lines
2.6 KiB
JavaScript
107 lines
2.6 KiB
JavaScript
'use strict'
|
|
|
|
var assert = require('node:assert')
|
|
var express = require('../')
|
|
, request = require('supertest');
|
|
|
|
describe('req', function(){
|
|
describe('.query', function(){
|
|
it('should default to {}', function(done){
|
|
var app = createApp();
|
|
|
|
request(app)
|
|
.get('/')
|
|
.expect(200, '{}', done);
|
|
});
|
|
|
|
it('should default to parse simple keys', function (done) {
|
|
var app = createApp();
|
|
|
|
request(app)
|
|
.get('/?user[name]=tj')
|
|
.expect(200, '{"user[name]":"tj"}', done);
|
|
});
|
|
|
|
describe('when "query parser" is extended', function () {
|
|
it('should parse complex keys', function (done) {
|
|
var app = createApp('extended');
|
|
|
|
request(app)
|
|
.get('/?foo[0][bar]=baz&foo[0][fizz]=buzz&foo[]=done!')
|
|
.expect(200, '{"foo":[{"bar":"baz","fizz":"buzz"},"done!"]}', done);
|
|
});
|
|
|
|
it('should parse parameters with dots', function (done) {
|
|
var app = createApp('extended');
|
|
|
|
request(app)
|
|
.get('/?user.name=tj')
|
|
.expect(200, '{"user.name":"tj"}', done);
|
|
});
|
|
});
|
|
|
|
describe('when "query parser" is simple', function () {
|
|
it('should not parse complex keys', function (done) {
|
|
var app = createApp('simple');
|
|
|
|
request(app)
|
|
.get('/?user%5Bname%5D=tj')
|
|
.expect(200, '{"user[name]":"tj"}', done);
|
|
});
|
|
});
|
|
|
|
describe('when "query parser" is a function', function () {
|
|
it('should parse using function', function (done) {
|
|
var app = createApp(function (str) {
|
|
return {'length': (str || '').length};
|
|
});
|
|
|
|
request(app)
|
|
.get('/?user%5Bname%5D=tj')
|
|
.expect(200, '{"length":17}', done);
|
|
});
|
|
});
|
|
|
|
describe('when "query parser" disabled', function () {
|
|
it('should not parse query', function (done) {
|
|
var app = createApp(false);
|
|
|
|
request(app)
|
|
.get('/?user%5Bname%5D=tj')
|
|
.expect(200, '{}', done);
|
|
});
|
|
});
|
|
|
|
describe('when "query parser" enabled', function () {
|
|
it('should not parse complex keys', function (done) {
|
|
var app = createApp(true);
|
|
|
|
request(app)
|
|
.get('/?user%5Bname%5D=tj')
|
|
.expect(200, '{"user[name]":"tj"}', done);
|
|
});
|
|
});
|
|
|
|
describe('when "query parser" an unknown value', function () {
|
|
it('should throw', function () {
|
|
assert.throws(createApp.bind(null, 'bogus'),
|
|
/unknown value.*query parser/)
|
|
});
|
|
});
|
|
})
|
|
})
|
|
|
|
function createApp(setting) {
|
|
var app = express();
|
|
|
|
if (setting !== undefined) {
|
|
app.set('query parser', setting);
|
|
}
|
|
|
|
app.use(function (req, res) {
|
|
res.send(req.query);
|
|
});
|
|
|
|
return app;
|
|
}
|