mirror of
https://github.com/zebrajr/express.git
synced 2025-12-06 00:19:48 +01:00
41113599af
Since v5 relies on node >= 18, this is now possible (since v16, v14.18.0 [^1][^2]). It's functionally irrelevant: 1. It's not required for CJS nor ESM (with a few exceptions [^3]) 2. It has no performance promises However, there are upsides to this approach: 1. It brings clear boundaries to what's a built-in and what's an external dependency 2. It reduces the risk of importing unwanted deps where a built-in is expected 3. It's slightly more interoperable with other JS runtimes that provide node compatibility[^4], albeit only during development. Once imported from npm, built-ins are assumed. [^1]:https://nodejs.org/docs/latest-v22.x/api/modules.html#built-in-modules [^2]:https://github.com/nodejs/node/pull/37246 [^3]:https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix [^4]:https://docs.deno.com/runtime/fundamentals/node/#using-node's-built-in-modules
63 lines
1.5 KiB
JavaScript
63 lines
1.5 KiB
JavaScript
'use strict'
|
|
|
|
var assert = require('node:assert')
|
|
var express = require('../')
|
|
, request = require('supertest');
|
|
|
|
describe('app', function(){
|
|
describe('.VERB()', function(){
|
|
it('should not get invoked without error handler on error', function(done) {
|
|
var app = express();
|
|
|
|
app.use(function(req, res, next){
|
|
next(new Error('boom!'))
|
|
});
|
|
|
|
app.get('/bar', function(req, res){
|
|
res.send('hello, world!');
|
|
});
|
|
|
|
request(app)
|
|
.post('/bar')
|
|
.expect(500, /Error: boom!/, done);
|
|
});
|
|
|
|
it('should only call an error handling routing callback when an error is propagated', function(done){
|
|
var app = express();
|
|
|
|
var a = false;
|
|
var b = false;
|
|
var c = false;
|
|
var d = false;
|
|
|
|
app.get('/', function(req, res, next){
|
|
next(new Error('fabricated error'));
|
|
}, function(req, res, next) {
|
|
a = true;
|
|
next();
|
|
}, function(err, req, res, next){
|
|
b = true;
|
|
assert.strictEqual(err.message, 'fabricated error')
|
|
next(err);
|
|
}, function(err, req, res, next){
|
|
c = true;
|
|
assert.strictEqual(err.message, 'fabricated error')
|
|
next();
|
|
}, function(err, req, res, next){
|
|
d = true;
|
|
next();
|
|
}, function(req, res){
|
|
assert.ok(!a)
|
|
assert.ok(b)
|
|
assert.ok(c)
|
|
assert.ok(!d)
|
|
res.sendStatus(204);
|
|
});
|
|
|
|
request(app)
|
|
.get('/')
|
|
.expect(204, done);
|
|
})
|
|
})
|
|
})
|