Douglas Christopher Wilson
ccc45a74f8
Merge tag '3.18.1'
2014-10-23 02:06:20 -04:00
Douglas Christopher Wilson
4dd970578a
Fix res.send to mention res.sendStatus
2014-10-23 01:35:16 -04:00
Douglas Christopher Wilson
af1043844f
Fix internal utils.merge deprecation warnings
2014-10-22 15:18:10 -04:00
Douglas Christopher Wilson
6f31218ecc
Use content-disposition module
2014-10-17 23:45:58 -04:00
Alex Upadhyay
6f0302fb78
Fix res.redirect body when redirect status specified
...
fixes #2402
fixes #2404
2014-10-17 22:00:59 -04:00
Douglas Christopher Wilson
0e5613363f
Use content-disposition module
2014-10-17 21:08:05 -04:00
Douglas Christopher Wilson
2c5ed88c90
Merge tag '3.17.8'
2014-10-16 01:27:44 -04:00
Bessie Chan
be478d348c
Fix typo in res.redirect deprecation
...
closes #2395
2014-10-11 18:11:22 -04:00
Seth Samuel
12f92a50dc
Add res.sendStatus
...
closes #2269
closes #2297
closes #2340
2014-09-09 00:24:11 -04:00
Douglas Christopher Wilson
2a0c35a108
Invoke callback for sendfile when client aborts
...
fixes #2189
fixes #2300
closes #2303
closes #2305
2014-09-09 00:12:49 -04:00
lemmy
d2d0afff64
Remove unused variable
...
closes #2345
2014-09-08 20:59:03 -04:00
Douglas Christopher Wilson
a57efea173
Fix original URL parsing in res.location
2014-08-10 22:20:54 -04:00
Douglas Christopher Wilson
1150ca7264
Fix incorrect deprecation warnings on res.download
...
fixes #2284
2014-08-06 17:48:36 -04:00
Douglas Christopher Wilson
8449f23f0d
Deprecate res.sendfile
2014-08-06 02:27:16 -04:00
Douglas Christopher Wilson
2cb029f896
Add res.sendFile
...
fixes #1906
closes #2266
2014-08-06 02:26:51 -04:00
Douglas Christopher Wilson
f34944c539
Merge tag '3.15.0'
2014-07-23 16:15:00 -04:00
Douglas Christopher Wilson
88cffadcaa
deps: send@0.7.0
2014-07-23 14:54:33 -04:00
Douglas Christopher Wilson
0d77305a1a
Pass options from res.sendfile to send
...
fixes #2017
2014-07-23 00:08:15 -04:00
Douglas Christopher Wilson
323c185079
deps: send@0.7.0
2014-07-23 00:05:45 -04:00
Douglas Christopher Wilson
fd3b40533b
Deprecate combined status, response signatures
...
closes #2227
2014-07-17 22:49:41 -04:00
Vasilyev Dmitry
fd86ab8da2
build: fix up jsdoc return values
...
closes #2243
2014-07-16 09:05:57 -04:00
Douglas Christopher Wilson
b43205ca98
perf: prevent multiple Buffer creation in res.send
2014-07-13 21:14:30 -04:00
Douglas Christopher Wilson
c6e6203020
perf: fix arguments reassign deopt in some res methods
2014-07-11 17:13:07 -04:00
Douglas Christopher Wilson
4ea6f21b02
Merge tag '3.14.0'
2014-07-11 16:28:37 -04:00
Douglas Christopher Wilson
b2382a7336
Remove unnecessary escaping in res.jsonp
2014-07-11 00:20:11 -04:00
Douglas Christopher Wilson
f684a64df7
Add explicit "Rosetta Flash JSONP abuse" protection
2014-07-11 00:15:55 -04:00
Douglas Christopher Wilson
5d03d0eac8
Deprecate res.redirect(url, status)
2014-07-10 23:21:16 -04:00
Yad Smood
544c6665f5
Fix res.send(status, num) to send num as json
...
fixes #2226
2014-07-10 23:19:57 -04:00
Douglas Christopher Wilson
ce3d1fe07e
Add headers option to res.sendfile
2014-07-03 12:53:49 -04:00
Douglas Christopher Wilson
381b3b0f77
add deprecation message to res.vary()
2014-06-23 16:26:28 -04:00
Douglas Christopher Wilson
ba8a4c5a8d
add deprecation message to res.send(body, status)
2014-06-23 16:26:00 -04:00
Douglas Christopher Wilson
3ffceff3ed
Merge tag '3.12.0'
2014-06-22 11:42:15 -04:00
Douglas Christopher Wilson
9c731f1883
deprecate things with depd module
2014-06-19 23:34:58 -04:00
Douglas Christopher Wilson
9bf1247716
Merge tag '3.10.3'
2014-06-05 23:45:31 -04:00
Jonathan Ong
6d65ae5ba6
use vary@0.1.0
...
with backwards compatibility
closes #2161
2014-06-05 19:32:32 -04:00
Douglas Christopher Wilson
402ec83157
Merge tag '3.10.0'
2014-06-03 00:47:39 -04:00
Douglas Christopher Wilson
f433b7c7cf
replace utils.escape with html-escape
2014-06-03 00:37:32 -04:00
Douglas Christopher Wilson
9e6b881f85
remove jsdoc params for polymorphic functions
...
until jsdoc has a way to actually document them
closes #2156
2014-06-02 10:26:15 -04:00
Douglas Christopher Wilson
db4448dda8
Merge tag '3.9.0'
2014-05-30 22:17:51 -04:00
Douglas Christopher Wilson
c21226aa7c
improve etag control for res.send
...
closes #1435
closes #2129
2014-05-30 21:02:21 -04:00
Tiago Relvao
3c0ec59432
Include ETag in HEAD requests
...
backport of commit 3c7310ebcb
2014-05-28 22:31:00 -04:00
Douglas Christopher Wilson
db4a061ed6
Merge tag '3.8.0'
2014-05-21 02:08:04 -04:00
Douglas Christopher Wilson
f14e39d451
set proper charset in content-type for res.send
...
This will write strings to sockets with an explicit "utf8" encoding
(which is the default) and will override the charset in the
Content-Type so it properly relfects the encoding of the response.
closes #1631
closes #2092
2014-05-21 01:31:08 -04:00
Alberto Leal
084f5d891b
Keep previous Content-Type for res.jsonp
...
backport of commit be997fd654
2014-05-21 01:04:29 -04:00
Douglas Christopher Wilson
65f13c3cc6
update connect to 2.16.1
2014-05-17 14:30:52 -04:00
Douglas Christopher Wilson
35c50601bd
Merge tag '3.6.0'
2014-05-09 17:33:26 -04:00
Douglas Christopher Wilson
4e1e252e17
deprecate res.json(obj, status)
...
closes #2106
closes #2107
2014-05-08 21:11:05 -04:00
Douglas Christopher Wilson
0bbbc84959
Merge branch '4.1.x'
2014-05-08 14:45:47 -04:00
Douglas Christopher Wilson
2901bd6916
Merge branch '3.5.x' into 4.1.x
2014-05-08 14:01:02 -04:00
Douglas Christopher Wilson
d58ca520c8
Fix res.jsonp error if callback param is object
...
fixes #2104
2014-05-08 13:42:19 -04:00
Alberto Leal
be997fd654
Keep previous Content-Type for res.jsonp
...
closes #2094
2014-05-02 15:01:19 -04:00
Tiago Relvao
3c7310ebcb
Include ETag in HEAD requests
...
fixes #2083
2014-04-30 09:34:10 -04:00
Douglas Christopher Wilson
1536a2196e
preserve casing of headers in res.header and res.set
...
fixes #2063
2014-04-24 18:00:43 -04:00
Douglas Christopher Wilson
2fd3e72a19
Pass options from res.sendfile to send
...
fixes #2017
2014-04-24 16:44:06 -04:00
Andy VanWagoner
56b672e657
support non-ascii filenames in content-disposition headers
2014-04-19 21:16:11 -06:00
agchou
13475977af
some code cleanup
2014-03-25 15:23:04 -07:00
Jonathan Ong
2064f412cb
remove res.charset usage
2014-03-07 16:46:54 -08:00
Jonathan Ong
bad55f7977
move setHeader charset patch to .set
...
note that application/json no longer adds charset=utf-8. could be a
regression.
closes #1952
See also: https://github.com/broofa/node-mime/issues/86
2014-03-07 16:32:41 -08:00
Jonathan Ong
5572897998
some jshint cleanup
...
some more errors but whatever
2014-03-05 22:24:35 -08:00
Jonathan Ong
3112f92d08
move the patch to the response proto
2014-03-05 22:20:58 -08:00
Roman Shtylman
d42d8f5b07
move support for multiple res.cookie calls to lib/response
...
Patch.js is simpler and follows upstream node.js closer as a result.
2014-02-22 09:26:30 -05:00
Roman Shtylman
6835289564
remove ServerResonse.headerSent monkey patch
...
node.js ServerResponse contains a headersSent field. Use that instead of
our patched misnamed version.
2014-02-22 09:26:29 -05:00
Roman Shtylman
1396e0855d
remove last pieces of connect dependency
...
- copy over patch.js to shim ServerResponse
- bundle `static` middleware
2014-02-22 09:26:29 -05:00
Jonathan Ong
aac1d52c4f
res.location: remove resolving relative urls
...
closes #1804
this is an unnecessary maintenance burden (see the number of removed
tests), especially when supporting mounting. browsers handle relative
locations, and so should all clients.
a regression could be absolute locations on a mounted app, but 1. we
can fix that later when someone complains and 2) code-smell
2014-02-08 11:37:43 -08:00
Roman Shtylman
63c6a9c5ad
use escape-html module to escape html
...
Another util bites the dust.
2014-01-24 19:21:21 -05:00
Roman Shtylman
718e68ffae
use utils-merge module to mixin object properties
2014-01-24 19:16:37 -05:00
TJ Holowaychuk
8a7a695836
ocd
2013-11-26 11:12:56 -08:00
Michael Ficarra
2f2a652bc9
fixes #1826 : res.redirect('toString') fails with 500
...
Removed the unused map and corrected the doc comment.
2013-11-26 13:11:15 -06:00
Jérémy Lal
b7a38af41d
Use url.resolve to compute location header of relative paths
2013-11-02 02:28:29 +01:00
Jérémy Lal
661914781e
semicolons
2013-11-02 00:39:32 +01:00
Jonathan Ong
55d1a4f964
always send ETag when content-length > 0
...
closes #1780
2013-10-30 20:34:16 -07:00
Jonathan Ong
9bed2b80ee
lint: remove unused stuff
2013-10-18 01:18:56 -07:00
TJ Holowaychuk
c9d9ed3493
fix res.sendfile() callback
...
what the hell... I was just told readable streams have finish not end,
make up your mind node!
2013-10-17 02:51:01 +00:00
Jonathan Ong
e218377a3d
check existence of jsonp callback
2013-10-15 12:39:32 -07:00
TJ Holowaychuk
3b4ce91fa3
refactor res.format() with a little ocd
2013-09-08 09:30:59 -07:00
Eduardo Sorribas
a887e6a881
Minor refactor of res.format
2013-09-08 02:34:52 -04:00
Eduardo Sorribas
69290cad6f
res.format() now includes charset. Fixes #1744
2013-09-08 02:10:46 -04:00
TJ Holowaychuk
8e2f538983
refactor res.links()
2013-09-07 15:26:12 -07:00
Eduardo Sorribas
7059d3b71e
Allow multiple call concatenation for res.links. Fixes #1683
2013-09-06 21:44:03 -04:00
cjihrig
e5de08faa1
add res.vary(). Closes #1682
2013-09-02 09:10:14 -07:00
TJ Holowaychuk
3ea7381dea
Merge pull request #1711 from jonjenkins/master
...
Fixes from pull request #1643
2013-09-02 08:55:23 -07:00
TJ Holowaychuk
6cf6c8b918
Revert "remove charset from json responses. Closes #1631 "
...
This reverts commit 138d74aefa .
2013-08-27 13:48:18 -07:00
Jon Jenkins
19cb39869f
Fixes from pull request #1643 , array method correction
2013-08-04 12:46:50 -05:00
Jon Jenkins
bdbdab7fcc
Fixes from pull request #1643
2013-08-03 16:33:15 -05:00
TJ Holowaychuk
8ad8cb93cc
refactor
2013-08-02 14:46:25 -07:00
Max Riveiro
54a192a5c5
Add application setting to disable ETag completely
2013-07-21 12:49:28 +04:00
TJ Holowaychuk
138d74aefa
remove charset from json responses. Closes #1631
2013-06-05 11:51:59 -07:00
Jenkins
2f19b4fefc
Corrected callback crashing app when array
2013-05-26 21:35:52 -05:00
TJ Holowaychuk
10b21b41f7
Revert "fix infinite loop when res.send(status) is undefined. Closes #1623 "
...
This reverts commit 28b8a3b5f7 .
2013-05-13 13:23:23 -07:00
TJ Holowaychuk
28b8a3b5f7
fix infinite loop when res.send(status) is undefined. Closes #1623
2013-05-13 13:22:31 -07:00
TJ Holowaychuk
3296ed9cb3
change generation of ETags with res.send() to GET requests only. Closes #1619
...
if for some reason this is not ideal for your use-case please let me know and comment in the issue
2013-05-10 14:43:59 -07:00
Hack Sparrow
6d39ed8ef7
Accept number as value of Signed Cookie
2013-04-23 22:53:35 +05:30
Pavel Brylov
9e684d45bc
add support for custom Accept parameters
2013-04-11 08:34:10 -07:00
Michael Ahlers
04b0c44bdf
Test cases document this.
2013-02-24 18:05:11 -05:00
Michael Ahlers
956aa0cfff
This works as expected, and has limited scope.
2013-02-24 13:40:51 -05:00
Michael Ahlers
d874476f0b
Proposal to allow relative redirects for applications that have been mounted at multiple paths.
2013-02-24 13:10:49 -05:00
TJ Holowaychuk
a4b2e48dfe
refactor res.set() array support
2013-01-23 20:31:25 -08:00
TJ Holowaychuk
57cda1578d
Merge pull request #1477 from gmethvin/set_array
...
Allow setting an array of header values in the response
2013-01-23 20:29:17 -08:00
TJ Holowaychuk
49abd7bec1
merge
2013-01-23 20:21:36 -08:00
Greg Methvin
4031aaa591
Allow setting an array of header values in the response
...
Make setting multiple header values using an array work as expected.
If the header value is an array, coerce the values to strings instead
of the entire array.
Fixes #1419 .
2013-01-22 18:32:22 -08:00
TJ Holowaychuk
ab75fa048e
refactor vhost example
2013-01-14 09:51:56 +01:00
TJ Holowaychuk
bb29da5980
refactor vhost example
2013-01-13 11:32:53 -08:00
Julian Gruber
a4d7b75129
implemented res.location
2013-01-13 16:07:11 +01:00
Greg Methvin
39ee6f8e79
Don't mangle the options object in res.cookie
...
Make a copy of the cookie options before mutating it to pass to
cookie.serialize. This prevents unexpected things from happening when
we try to use the same options object multiple times.
Also add a test to verify that the options object does not change
after a request is made.
2013-01-03 02:00:15 -05:00
Guillermo Rauch
64a234958a
fix jsonp whitespace escape. Closes #1132
2012-12-28 10:24:55 -07:00
Alex Weeks
a1e42ac33f
Explicitly remove Transfer-Encoding header from 204 and 304 responses
...
Per RFC 2616 §10.3.6 & §10.2.5 (http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html ) "The [204/304] response MUST NOT contain a message-body, and thus is always terminated by the first empty line after the header fields."
2012-12-19 10:53:17 -08:00
TJ Holowaychuk
9bd86cdddc
Revert "add 'etag' option"
...
This reverts commit 6f6eec7d8d .
2012-12-06 15:15:49 -08:00
Max Riveiro
6f6eec7d8d
add 'etag' option
2012-12-05 16:49:09 -08:00
TJ Holowaychuk
c8526932f3
Merge branch 'master' of github.com:visionmedia/express
2012-11-21 08:43:13 -08:00
Greg Methvin
ea5e254c7d
Escape URLs in text/plain res.redirect response
...
Escape the URL printed by res.redirect using URL encoding. This
prevents some browsers (primarily old versions of IE) from attempting
to sniff the Content-Type and evaluate it as HTML, which causes a
cross-site scripting vulnerability.
2012-11-21 02:22:37 -05:00
TJ Holowaychuk
ab9c275bde
fix cookie max-age
...
the cookie module we depend on never used to
set this value, however now it does :)
2012-11-13 09:08:37 -08:00
Dmitry Bochkarev
6b309a4457
remove connect.static.send import from response.js
2012-11-08 12:43:38 +05:00
TJ Holowaychuk
2d49c0d1f3
Merge branch 'master' of github.com:visionmedia/express
2012-11-04 12:28:53 -08:00
TJ Holowaychuk
612fc47044
update connect
2012-11-01 17:27:33 -07:00
Roman Shtylman
dadf57cc8b
remove unused variables
...
Tests and examples with unused variables are unchanged.
2012-10-27 16:04:00 -04:00
TJ Holowaychuk
c29cfa823d
change res.redirect() to utilize a pathname-relative Location again. Closes #1382
...
nginx does not seem to set Host correctly,
though Location should be relative as per RFC
myself nor anyone else can report a client
that does not handle relative correctly so
this will be fine until then
2012-10-23 14:08:18 -07:00
TJ Holowaychuk
b3936b96e5
add cb && cb(payload) to res.jsonp(). Closes #1374
2012-10-16 11:57:37 -07:00
TJ Holowaychuk
56ffab045e
add backwards compat for res.redirect() status. Closes #1336
2012-09-26 09:07:22 -07:00
TJ Holowaychuk
f0d5b3b368
remove non-primitive string support for res.send()
...
kinda silly.. valueOf() before if you happen to use
boxed strings, otherwise it is unfair that dont support
other boxed primitives all over, and quite frankly no one does
2012-09-26 09:04:26 -07:00
TJ Holowaychuk
88072a56ea
refactor
2012-09-26 09:01:55 -07:00
TJ Holowaychuk
0d3a637389
add support for res.json() to retain previously defined Content-Types. Closes #1349
2012-09-26 09:00:52 -07:00
TJ Holowaychuk
8edf358739
refactor res.format(), dont pass "default" to req.accepts()
2012-09-03 16:16:46 -07:00
TJ Holowaychuk
a6caa267bd
add res.jsonp(). Closes #1307
...
this also removes the jsonp
2012-08-30 09:29:43 -07:00
TJ Holowaychuk
f2f09767fb
add etag util
2012-08-30 08:27:57 -07:00
TJ Holowaychuk
89c5affc3b
fix jsonp callback char restrictions
2012-08-28 18:11:49 -07:00
Tony Edwards
0217e6ce96
Fix signed cookie prefix
...
Update res.cookie to prefix signed cookies with 's:'
2012-08-13 20:01:17 -07:00
TJ Holowaychuk
6bebe0837f
refactor res.render() to prevent clobbering "locals"
2012-08-11 15:04:54 -07:00
TJ Holowaychuk
bac0c64633
escape res.redirect() link
2012-08-02 19:41:37 -07:00
TJ Holowaychuk
214f913b0c
merge
2012-07-24 13:28:13 -07:00
Ruben Verborgh
8050308706
Remove socket error handler if file was sent successfully.
2012-07-24 11:57:02 +02:00
TJ Holowaychuk
8f4e61a474
fix res.render docs
2012-07-20 17:22:21 -07:00
TJ Holowaychuk
a93d375acc
add res.redirect("//foo.com") support
2012-07-18 09:29:11 -07:00
TJ Holowaychuk
d66f0e5eb9
change res.redirect() to use scheme-relative urls
2012-07-18 09:07:21 -07:00
TJ Holowaychuk
ab61837885
change res.sendfile() to use send() module
2012-07-13 08:58:40 -07:00
riadh
5426eb0b62
add "jsonp callback name" setting
2012-07-06 08:53:31 -07:00
TJ Holowaychuk
4f7c4d1051
remove app.locals.use and res.locals.use
...
there are a few reasons for this:
a) less API, simpler implementation ...
b) difficult to inherit cleanly from subapps
c) effectively the same as parallelized middleware (use connect-parallel for example)
lastly this api in a sense promotes some obscure uses since
they may be scattered throughout rather than explicitly
given to specific routes or used globally as middleware etc
2012-07-05 18:46:19 -07:00
TJ Holowaychuk
96e4014a70
Replace res.send() with res.send = require("response-send")
2012-07-03 21:09:17 -07:00
TJ Holowaychuk
2e8d44b444
docs
2012-06-27 13:36:12 -07:00
TJ Holowaychuk
70d68419b0
Added res.json(obj, status) support back for BC
2012-06-27 13:34:53 -07:00
TJ Holowaychuk
3c0c96114f
Added res.send(body, status) support back for backwards compat
2012-06-21 16:37:26 -07:00
TJ Holowaychuk
362c96c8c1
refactor res.redirect() relative check
2012-06-21 08:25:43 -07:00
TJ Holowaychuk
e6129d8ba5
Added res.links(obj)
2012-06-17 16:34:42 -07:00
TJ Holowaychuk
d2baf11b8a
docs
2012-06-17 13:21:13 -07:00
TJ Holowaychuk
82b5b12ca7
Added .default() support to res.format()
2012-06-17 13:15:55 -07:00
TJ Holowaychuk
d073e0aeb5
Added 2xx / 304 check to req.fresh
2012-06-15 16:03:20 -07:00
TJ Holowaychuk
ce7293de13
misc
2012-06-15 15:44:44 -07:00
TJ Holowaychuk
108e66c24b
Fixed res.send() freshness check, respect res.statusCode
2012-06-15 15:42:46 -07:00
TJ Holowaychuk
640cf4ca21
Changed: res.send() always checks freshness
2012-06-15 11:38:51 -07:00
TJ Holowaychuk
0acee67339
Merge branch 'master' of github.com:visionmedia/express
2012-06-08 09:47:56 -07:00
TJ Holowaychuk
895673141d
Fixed: expose connects mime module. Cloases #1165
2012-06-08 09:47:13 -07:00