Shivam Sharma
98c85eb0dd
chore: enforce explicit Buffer import and add lint rule ( #6525 )
...
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
2025-06-27 20:10:36 -05:00
Jon Church
9f4dbe3a13
chore: wider range for query test skip ( #6512 )
2025-05-15 11:40:26 -05:00
Szymon Łągiewka
41113599af
fix(refactor): prefix built-in node module imports
...
Since v5 relies on node >= 18, this is now possible (since v16, v14.18.0
[^1][^2]).
It's functionally irrelevant:
1. It's not required for CJS nor ESM (with a few exceptions [^3])
2. It has no performance promises
However, there are upsides to this approach:
1. It brings clear boundaries to what's a built-in and what's an
external dependency
2. It reduces the risk of importing unwanted deps where a built-in is
expected
3. It's slightly more interoperable with other JS runtimes that provide
node compatibility[^4], albeit only during development. Once imported
from npm, built-ins are assumed.
[^1]:https://nodejs.org/docs/latest-v22.x/api/modules.html#built-in-modules
[^2]:https://github.com/nodejs/node/pull/37246
[^3]:https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix
[^4]:https://docs.deno.com/runtime/fundamentals/node/#using-node's-built-in-modules
2025-01-10 11:53:44 -06:00
Phillip9587
9f8589e31c
cleanup: remove unnecessary require for global Buffer
...
The Buffer object is globally available in Node.js, so there is no need to explicitly require it.
2024-11-15 10:16:29 -06:00
Bhavya Dhiman
c70197ad33
fix(buffer): use node:buffer instead of safe-buffer ( #6071 )
...
Main Changes:
- Removed dependency `safe-buffer@5.2.1`
- Use `node:buffer` core library instead of safe-buffer
2024-10-27 11:10:33 +01:00
Jon Church
61421a8c0c
skip QUERY tests for Node 21 only, still not supported ( #5695 )
...
* skip QUERY tests for Node 21 only, still not supported
QUERY support has now landed in Node 22.2.0, but is still not supported
in 21.7.3
QUERY showed up in http.METHODS in 21.7.2. Only Node versions after that
will attempt to run tests for it, based on the way we dynamically test
members of the http.METHODS array from Node
* update CI to run on 21.7 and 22.2
2024-06-08 23:25:42 -04:00
Chris de Almeida
689073d657
✨ bring back query tests for node 21 ( #5690 )
2024-06-05 17:25:58 -04:00
Jon Church
b44191eb3d
ignore ETAG query test as well, reuse skip util ( #5639 )
2024-05-04 18:01:42 -04:00
Douglas Christopher Wilson
291993d73c
tests: expand res.sendFile options tests
2022-03-01 00:22:09 -05:00
Douglas Christopher Wilson
6f7a8301a1
tests: add express.static test suite
2019-05-02 17:49:29 -04:00
Douglas Christopher Wilson
12bc16e72f
tests: use supertest to check response header values
...
closes #2983
closes #2992
2016-05-11 08:50:38 +02:00
