Shivam Sharma
|
98c85eb0dd
|
chore: enforce explicit Buffer import and add lint rule (#6525)
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
|
2025-06-27 20:10:36 -05:00 |
|
Noritaka Kobayashi
|
dfd1851245
|
test: fix typos in test descriptions (#6535)
|
2025-05-27 10:36:50 +02:00 |
|
Szymon Łągiewka
|
41113599af
|
fix(refactor): prefix built-in node module imports
Since v5 relies on node >= 18, this is now possible (since v16, v14.18.0
[^1][^2]).
It's functionally irrelevant:
1. It's not required for CJS nor ESM (with a few exceptions [^3])
2. It has no performance promises
However, there are upsides to this approach:
1. It brings clear boundaries to what's a built-in and what's an
external dependency
2. It reduces the risk of importing unwanted deps where a built-in is
expected
3. It's slightly more interoperable with other JS runtimes that provide
node compatibility[^4], albeit only during development. Once imported
from npm, built-ins are assumed.
[^1]:https://nodejs.org/docs/latest-v22.x/api/modules.html#built-in-modules
[^2]:https://github.com/nodejs/node/pull/37246
[^3]:https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix
[^4]:https://docs.deno.com/runtime/fundamentals/node/#using-node's-built-in-modules
|
2025-01-10 11:53:44 -06:00 |
|
Phillip Barta
|
4e92ac9031
|
cleanup: remove AsyncLocalStorage check from tests (#6147)
Co-authored-by: Wes Todd <wes@wesleytodd.com>
|
2024-11-15 10:23:42 -06:00 |
|
Phillip9587
|
9f8589e31c
|
cleanup: remove unnecessary require for global Buffer
The Buffer object is globally available in Node.js, so there is no need to explicitly require it.
|
2024-11-15 10:16:29 -06:00 |
|
Bhavya Dhiman
|
c70197ad33
|
fix(buffer): use node:buffer instead of safe-buffer (#6071)
Main Changes:
- Removed dependency `safe-buffer@5.2.1`
- Use `node:buffer` core library instead of safe-buffer
|
2024-10-27 11:10:33 +01:00 |
|
Wes Todd
|
e9f9aaeebd
|
Merge tag '4.19.0' into 5.x
4.19.0
|
2024-03-20 21:14:00 -05:00 |
|
Douglas Christopher Wilson
|
2e2d78c4d9
|
deps: on-finished@2.4.1
|
2022-04-03 01:15:37 -04:00 |
|
Douglas Christopher Wilson
|
03dc367187
|
Allow options without filename in res.download
|
2022-03-25 18:13:42 -04:00 |
|
Tommaso Tofacchi
|
0def9bb659
|
Add "root" option to res.download
fixes #4834
closes #4855
|
2022-03-25 00:08:38 -04:00 |
|
Douglas Christopher Wilson
|
8da8f79c44
|
tests: fix callback in res.download test
|
2022-02-23 00:20:34 -05:00 |
|
Douglas Christopher Wilson
|
18f782bba9
|
tests: remove duplicate utils
|
2022-02-23 00:18:36 -05:00 |
|
Douglas Christopher Wilson
|
318fd4b543
|
Merge tag '4.17.3'
|
2022-02-17 00:27:11 -05:00 |
|
Douglas Christopher Wilson
|
a65913776d
|
tests: use strict mode
|
2022-02-09 01:07:08 -05:00 |
|
Douglas Christopher Wilson
|
669c805615
|
deps: send@1.0.0-beta.1
|
2022-02-08 09:57:29 -05:00 |
|
Douglas Christopher Wilson
|
2585f209f9
|
tests: fix test missing assertion
|
2022-02-04 21:18:47 -05:00 |
|
Douglas Christopher Wilson
|
da6cb0ed8a
|
tests: add range tests to res.download
|
2022-02-02 15:15:41 -05:00 |
|
김정환
|
b9b1b19758
|
tests: fix typos in descriptions
closes #3875
|
2019-04-16 12:40:59 -04:00 |
|
Douglas Christopher Wilson
|
451ee5d9c1
|
build: supertest@3.3.0
|
2018-09-24 23:40:21 -04:00 |
|
Aaron Clover
|
a24fd0ca6c
|
Add options to res.download
closes #3327
closes #3370
|
2017-09-28 11:11:08 -04:00 |
|
Douglas Christopher Wilson
|
e0066227f7
|
lint: remove all unused varaibles
|
2017-08-06 00:19:32 -04:00 |
|
Douglas Christopher Wilson
|
ca480d7043
|
tests: improve res.download tests
|
2015-02-16 17:54:36 -05:00 |
|
Douglas Christopher Wilson
|
1f2e00ef8d
|
deps: should@~4.0.0
|
2014-05-29 22:53:59 -04:00 |
|
Jonathan Ong
|
328c6d3060
|
remove unnecessary test/support/http
backport of 643397ed21
|
2014-05-18 00:57:54 -04:00 |
|
TJ Holowaychuk
|
48be9233d8
|
add res.download() content-disposition on error removal test
|
2012-07-13 09:24:09 -07:00 |
|
TJ Holowaychuk
|
0f5560eebd
|
updated tests to use "supertest"
|
2012-06-26 17:14:07 -07:00 |
|
TJ Holowaychuk
|
cdca9cf88f
|
Added res.download() body test
|
2012-05-10 17:15:50 -07:00 |
|
TJ Holowaychuk
|
5840b42f4a
|
Added res.download() tests
|
2012-05-10 17:11:43 -07:00 |
|