Szymon Łągiewka
|
41113599af
|
fix(refactor): prefix built-in node module imports
Since v5 relies on node >= 18, this is now possible (since v16, v14.18.0
[^1][^2]).
It's functionally irrelevant:
1. It's not required for CJS nor ESM (with a few exceptions [^3])
2. It has no performance promises
However, there are upsides to this approach:
1. It brings clear boundaries to what's a built-in and what's an
external dependency
2. It reduces the risk of importing unwanted deps where a built-in is
expected
3. It's slightly more interoperable with other JS runtimes that provide
node compatibility[^4], albeit only during development. Once imported
from npm, built-ins are assumed.
[^1]:https://nodejs.org/docs/latest-v22.x/api/modules.html#built-in-modules
[^2]:https://github.com/nodejs/node/pull/37246
[^3]:https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix
[^4]:https://docs.deno.com/runtime/fundamentals/node/#using-node's-built-in-modules
|
2025-01-10 11:53:44 -06:00 |
|
Douglas Christopher Wilson
|
a65913776d
|
tests: use strict mode
|
2022-02-09 01:07:08 -05:00 |
|
Douglas Christopher Wilson
|
bd4fdfe5f7
|
tests: remove global dependency on should
fixes #4797
|
2022-02-02 01:55:16 -05:00 |
|
Douglas Christopher Wilson
|
56e90e3c72
|
lint: add eslint rules that cover editorconfig
|
2017-08-05 23:37:39 -04:00 |
|
chainhelen
|
eece3850bc
|
tests: use path.join instead of concatenation
closes #3236
|
2017-03-05 23:08:47 -05:00 |
|
Eric Ferraiuolo
|
75e47f2883
|
Add test for "view engine" setting with leading ".".
|
2013-01-24 00:55:55 -05:00 |
|
TJ Holowaychuk
|
67ca22b6e4
|
throw when callback is not given to app.engine()
|
2012-04-04 12:30:25 -07:00 |
|
Tj Holowaychuk
|
e9d7b6fbad
|
Changed template engine signature to engine.__express(path, options, fn). Closes #878
|
2011-11-10 13:42:08 -08:00 |
|
Tj Holowaychuk
|
52e26697a9
|
Added index.<engine> render test
|
2011-11-08 20:22:27 -08:00 |
|
Tj Holowaychuk
|
fdf620b688
|
more tests
|
2011-11-08 20:18:07 -08:00 |
|
Tj Holowaychuk
|
66f8ca52d6
|
Added app.engine() tests
|
2011-11-08 20:14:53 -08:00 |
|