Fixed flash example. Closes #392

examples/flash/app.js

@@ -26,23 +26,30 @@ app.set('view engine', 'ejs');
 
 app.dynamicHelpers({
     messages: function(req, res){
-        // Grab the flash messages
-        var messages = req.flash();
-        // We will render the "messages.ejs" partial
-        return res.partial('messages', {
-            // Our target object is our messages
-            object: messages,
-            // We want it to be named "types" in the partial
-            // since they are keyed like this:
-            // { info: ['foo'], error: ['bar']}
-            as: 'types',
-            // Pass a local named "hasMessages" so we can easily
-            // check if we have any messages at all
-            locals: { hasMessages: Object.keys(messages).length },
-            // We dont want dynamicHelpers in this partial, as
-            // it would cause infinite recursion
-            dynamicHelpers: false
-        });
+        // In the case of flash messages
+        // we return a function, allowing
+        // flash messages to only be flushed
+        // when called, otherwise every request
+        // will flush flash messages regardless.
+        return function(){
+            // Grab the flash messages
+            var messages = req.flash();
+            // We will render the "messages.ejs" partial
+            return res.partial('messages', {
+                // Our target object is our messages
+                object: messages,
+                // We want it to be named "types" in the partial
+                // since they are keyed like this:
+                // { info: ['foo'], error: ['bar']}
+                as: 'types',
+                // Pass a local named "hasMessages" so we can easily
+                // check if we have any messages at all
+                locals: { hasMessages: Object.keys(messages).length },
+                // We dont want dynamicHelpers in this partial, as
+                // it would cause infinite recursion
+                dynamicHelpers: false
+            });
+        }
     }
 });
 

examples/flash/views/index.ejs

@@ -1,2 +1,2 @@
 <h1>Flash Message Example</h1>
-<%- messages %>
+<%- messages() %>