From 89f198c6a50ab0cb65b741767791dd1b647e3b2c Mon Sep 17 00:00:00 2001 From: Sebastian Beltran Date: Thu, 21 Aug 2025 10:05:29 -0500 Subject: [PATCH] lib: use req.socket over deprecated req.connection (#6705) Signed-off-by: Sebastian Beltran --- lib/request.js | 6 +++--- test/req.protocol.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/request.js b/lib/request.js index 63e0c1cd..69990da3 100644 --- a/lib/request.js +++ b/lib/request.js @@ -282,12 +282,12 @@ req.is = function is(types) { */ defineGetter(req, 'protocol', function protocol(){ - var proto = this.connection.encrypted + var proto = this.socket.encrypted ? 'https' : 'http'; var trust = this.app.get('trust proxy fn'); - if (!trust(this.connection.remoteAddress, 0)) { + if (!trust(this.socket.remoteAddress, 0)) { return proto; } @@ -406,7 +406,7 @@ defineGetter(req, 'host', function host(){ var trust = this.app.get('trust proxy fn'); var val = this.get('X-Forwarded-Host'); - if (!val || !trust(this.connection.remoteAddress, 0)) { + if (!val || !trust(this.socket.remoteAddress, 0)) { val = this.get('Host'); } else if (val.indexOf(',') !== -1) { // Note: X-Forwarded-Host is normally only ever a diff --git a/test/req.protocol.js b/test/req.protocol.js index 61f76356..def82eda 100644 --- a/test/req.protocol.js +++ b/test/req.protocol.js @@ -39,7 +39,7 @@ describe('req', function(){ app.enable('trust proxy'); app.use(function(req, res){ - req.connection.encrypted = true; + req.socket.encrypted = true; res.end(req.protocol); });