mirror of
https://github.com/zebrajr/express.git
synced 2025-12-06 00:19:48 +01:00
✨ bring back query tests for node 21 (#5690)
This commit is contained in:
parent
2803a2b35a
commit
689073d657
9
.github/workflows/ci.yml
vendored
9
.github/workflows/ci.yml
vendored
|
|
@ -148,15 +148,6 @@ jobs:
|
|||
nvm install --default ${{ matrix.node-version }}
|
||||
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
|
||||
|
||||
- name: Configure npm
|
||||
run: |
|
||||
npm config set loglevel error
|
||||
if [[ "$(npm config get package-lock)" == "true" ]]; then
|
||||
npm config set package-lock false
|
||||
else
|
||||
npm config set shrinkwrap false
|
||||
fi
|
||||
|
||||
- name: Install npm module(s) ${{ matrix.npm-i }}
|
||||
run: npm install --save-dev ${{ matrix.npm-i }}
|
||||
if: matrix.npm-i != ''
|
||||
|
|
|
|||
|
|
@ -77,12 +77,11 @@ function getMajorVersion(versionString) {
|
|||
}
|
||||
|
||||
function shouldSkipQuery(versionString) {
|
||||
// Temporarily skipping this test on 21 and 22
|
||||
// Temporarily skipping this test on 22
|
||||
// update this implementation to run on those release lines on supported versions once they exist
|
||||
// upstream tracking https://github.com/nodejs/node/pull/51719
|
||||
// express tracking issue: https://github.com/expressjs/express/issues/5615
|
||||
var majorsToSkip = {
|
||||
"21": true,
|
||||
"22": true
|
||||
}
|
||||
return majorsToSkip[getMajorVersion(versionString)]
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user