bring back query tests for node 21 (#5690)

This commit is contained in:
Chris de Almeida 2024-06-05 16:25:58 -05:00 committed by GitHub
parent 2803a2b35a
commit 689073d657
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 12 deletions

View File

@ -148,15 +148,6 @@ jobs:
nvm install --default ${{ matrix.node-version }}
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
- name: Configure npm
run: |
npm config set loglevel error
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi
- name: Install npm module(s) ${{ matrix.npm-i }}
run: npm install --save-dev ${{ matrix.npm-i }}
if: matrix.npm-i != ''

1
.npmrc Normal file
View File

@ -0,0 +1 @@
package-lock=false

View File

@ -77,12 +77,11 @@ function getMajorVersion(versionString) {
}
function shouldSkipQuery(versionString) {
// Temporarily skipping this test on 21 and 22
// Temporarily skipping this test on 22
// update this implementation to run on those release lines on supported versions once they exist
// upstream tracking https://github.com/nodejs/node/pull/51719
// express tracking issue: https://github.com/expressjs/express/issues/5615
var majorsToSkip = {
"21": true,
"22": true
}
return majorsToSkip[getMajorVersion(versionString)]