OSSForks/express
1
0
Fork 0
mirror of https://github.com/zebrajr/express.git synced 2025-12-06 12:19:51 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix hanging on large stack of sync routes

Browse Source 
fixes #4899
This commit is contained in:
Douglas Christopher Wilson 2022-04-29 13:34:47 -04:00
parent 75e0c7a2c9
commit 631ada0c64
3 changed files with 28 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
History.md
View File

@ -1,3 +1,8 @@
unreleased
==========
* Fix hanging on large stack of sync routes
4.18.0 / 2022-04-25 4.18.0 / 2022-04-25
=================== ===================

14
lib/router/index.js
View File

@ -279,14 +279,14 @@ proto.handle = function handle(req, res, out) {
// this should be done for the layer // this should be done for the layer
self.process_params(layer, paramcalled, req, res, function (err) { self.process_params(layer, paramcalled, req, res, function (err) {
if (err) { if (err) {
return next(layerError || err); next(layerError || err)
} else if (route) {
layer.handle_request(req, res, next)
} else {
trim_prefix(layer, layerError, layerPath, path)
} }
if (route) { sync = 0
return layer.handle_request(req, res, next);
}
trim_prefix(layer, layerError, layerPath, path);
}); });
} }
@ -327,8 +327,6 @@ proto.handle = function handle(req, res, out) {
} else { } else {
layer.handle_request(req, res, next); layer.handle_request(req, res, next);
} }
sync = 0
} }
}; };

18
test/Router.js
View File

@ -78,7 +78,23 @@ describe('Router', function(){
router.handle({ url: '/', method: 'GET' }, { end: done }); router.handle({ url: '/', method: 'GET' }, { end: done });
}); });
it('should not stack overflow with a large sync stack', function (done) { it('should not stack overflow with a large sync route stack', function (done) {
this.timeout(5000) // long-running test
var router = new Router()
for (var i = 0; i < 6000; i++) {
router.get('/foo', function (req, res, next) { next() })
}
router.get('/foo', function (req, res) {
res.end()
})
router.handle({ url: '/foo', method: 'GET' }, { end: done })
})
it('should not stack overflow with a large sync middleware stack', function (done) {
this.timeout(5000) // long-running test this.timeout(5000) // long-running test
var router = new Router() var router = new Router()