OSSForks/ansible
1
0
Fork 0
mirror of https://github.com/zebrajr/ansible.git synced 2025-12-06 00:19:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

sanity: warn on ansible.module_utils.six imports (#85651)

Browse Source 
Co-authored-by: Matt Clay <matt@mystile.com>
This commit is contained in:
Martin Krizek 2025-08-28 08:03:48 +02:00 committed by GitHub
parent 3ec07418aa
commit b3ef4f7671
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 30 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
test/lib/ansible_test/_util/controller/sanity/pylint/plugins/unwanted.py
View File

@ -80,36 +80,39 @@ class AnsibleUnwantedChecker(BaseChecker):
'Identifies imports which should not be used.'),
)
unwanted_imports = dict(
# Additional imports that we may want to start checking:
# boto=UnwantedEntry('boto3', modules_only=True),
# requests=UnwantedEntry('ansible.module_utils.urls', modules_only=True),
# urllib=UnwantedEntry('ansible.module_utils.urls', modules_only=True),
unwanted_imports = {
# see https://docs.python.org/2/library/urllib2.html
urllib2=UnwantedEntry('ansible.module_utils.urls',
ignore_paths=(
'/lib/ansible/module_utils/urls.py',
)),
'urllib2': UnwantedEntry(
'ansible.module_utils.urls',
ignore_paths=(
'/lib/ansible/module_utils/urls.py',
)
),
# see https://docs.python.org/3/library/collections.abc.html
collections=UnwantedEntry('ansible.module_utils.six.moves.collections_abc',
names=(
'MappingView',
'ItemsView',
'KeysView',
'ValuesView',
'Mapping', 'MutableMapping',
'Sequence', 'MutableSequence',
'Set', 'MutableSet',
'Container',
'Hashable',
'Sized',
'Callable',
'Iterable',
'Iterator',
)),
)
'collections': UnwantedEntry(
'collections.abc',
names=(
'MappingView',
'ItemsView',
'KeysView',
'ValuesView',
'Mapping', 'MutableMapping',
'Sequence', 'MutableSequence',
'Set', 'MutableSet',
'Container',
'Hashable',
'Sized',
'Callable',
'Iterable',
'Iterator',
)
),
'ansible.module_utils.six': UnwantedEntry(
'the Python standard library equivalent'
),
}
unwanted_functions = {
# see https://docs.python.org/3/library/tempfile.html#tempfile.mktemp