OSSForks/ansible
1
0
Fork 0
mirror of https://github.com/zebrajr/ansible.git synced 2025-12-06 00:19:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix paramiko deprecation unit test (#85573)

Browse Source 
The unit test previously assumed paramiko was installed, and would fail if it was not.
This commit is contained in:
Matt Clay 2025-07-28 13:47:14 -07:00 committed by GitHub
parent 9b266da14f
commit 43a20c9f68
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/units/plugins/connection/test_paramiko_ssh.py
View File

@ -18,8 +18,10 @@
from __future__ import annotations
import sys
from io import StringIO
import pytest
import typing as t
from ansible.module_utils import _internal
from ansible.plugins.connection import paramiko_ssh as paramiko_ssh_module
@ -59,17 +61,25 @@ def test_paramiko_connect(play_context, in_stream, mocker):
assert connection._connected is True
def test_deprecation_warning_controller():
def test_deprecation_warning_controller(monkeypatch: pytest.MonkeyPatch) -> None:
"""Ensures deprecation warnings are generated for external paramiko imports."""
assert _internal.is_controller
sentinel: t.Any = object()
monkeypatch.delitem(sys.modules, 'ansible')
monkeypatch.delitem(sys.modules, 'ansible.module_utils')
monkeypatch.delitem(sys.modules, 'ansible.module_utils.compat')
monkeypatch.delitem(sys.modules, 'ansible.module_utils.compat.paramiko')
monkeypatch.setitem(sys.modules, 'paramiko', sentinel)
# ensure direct access to `_` prefixed attrs does not warn
with emits_warnings(deprecation_pattern=[], warning_pattern=[]):
from ansible.module_utils.compat import paramiko
assert paramiko._paramiko is not None
assert paramiko._paramiko is sentinel
assert isinstance(paramiko._PARAMIKO_IMPORT_ERR, (Exception, type(None)))
with emits_warnings(deprecation_pattern=["The 'paramiko' compat import is deprecated", "The 'PARAMIKO_IMPORT_ERR' compat import is deprecated"]):
from ansible.module_utils.compat import paramiko
assert paramiko.paramiko is not None
assert paramiko.paramiko is sentinel
assert isinstance(paramiko.PARAMIKO_IMPORT_ERR, (Exception, type(None)))