Always switch to achievements page first

Add a few other documentation corrections too, including the README.

README.MD

@@ -55,19 +55,23 @@ I know you linux geeks love to use command line options! SamRewritten has a few,
 Usage:
   samrewritten [AppId] [OPTION...]
 
-      --apps        Get the list of your owned apps.
-  -h, --help        Show CLI help.
-  -a, --app arg     Set which AppId you want to use. Same as using positional
-                    'AppId'
-  -i, --idle        Set your Steam profile as 'ingame'. Ctrl+c to stop.
-      --ls          Display achievements and stats for selected app.
-      --sort arg    Sort option for --ls. You can leave empty or set to
-                    'unlock_rate'
-      --unlock arg  Unlock achievements for an AppId. Separate achievement
-                    names by a comma.
-      --lock arg    Lock achievements for an AppId. Separate achievement
-                    names by a comma.
-      --launch      Actually just launch the app.
+      --apps            Get the list of your owned apps.
+  -h, --help            Show CLI help.
+  -a, --app arg         Set which AppId you want to use. Same as using
+                        positional 'AppId'
+  -i, --idle            Set your Steam profile as 'ingame'. Ctrl+c to stop.
+      --ls              Display achievements and stats for selected app.
+      --sort arg        Sort option for --ls. You can leave empty or set to
+                        'unlock_rate'
+      --unlock arg      Unlock achievements for an AppId. Separate
+                        achievement names by a comma.
+      --lock arg        Lock achievements for an AppId. Separate achievement
+                        names by a comma.
+      --statnames arg   Change stats for an AppId. Separate stat names by a
+                        comma. Use with statvalues to name the values in order
+      --statvalues arg  Change stats for an AppId. Separate stat values by a
+                        comma. Use with statnames to name the values in order
+      --launch          Actually just launch the app.
 ```
 
 ---

src/controller/MySteam.cpp

@@ -261,7 +261,8 @@ MySteam::remove_modification_stat(const StatValue_t& stat) {
 // => remove_modification_stat
 
 /**
- * Commit pending achievement and stat changes
+ * Commit pending achievement and stat changes and clear the current
+ * list because it's now stale
  */
 void
 MySteam::commit_changes() {
@@ -279,7 +280,7 @@ MySteam::commit_changes() {
     std::string response = m_ipc_socket->request_response(make_commit_changes_request_string(achievement_changes, stat_changes));
 
     if (!decode_ack(response)) {
-        std::cerr << "Failed to store achievement changes!" << std::endl;
+        std::cerr << "Failed to commit changes!" << std::endl;
     }
 
     // Clear all pending changes

src/gui/MainPickerWindow.cpp

@@ -385,6 +385,9 @@ MainPickerWindow::switch_to_achievement_page() {
     m_game_search_bar->set_visible(false);
 
     m_main_stack->set_visible_child(*m_achievement_and_stat_notebook);
+    // Always switch to achievements page because a previously
+    // launched app may have left it on the stat tab
+    m_achievement_and_stat_notebook->set_current_page(0);
 }
 // => switch_to_achievement_page
 

src/sockets/MyGameSocket.h

@@ -21,7 +21,7 @@ public:
     void populate_stats_and_achievements(void);
     bool get_global_stats(void);
     bool get_global_achievements_stats(void);
-    void process_changes(std::vector<AchievementChange_t> changes, std::vector<StatChange_t> changes2);
+    void process_changes(std::vector<AchievementChange_t> achievement_changes, std::vector<StatChange_t> stat_changes);
 
     /**
      * Simple getters